Fix bug where clusterctl move does not work, and add correct default … #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where clusterctl move does not work, and add correct default label
What this PR does / why we need it:
clusterctl move was not working in CAPOCI. This was because CAPOCI used the cluster UID to tag all OCI resources created, and during reconciliation, made sure that the tags matched. But during move, the cluster UID changes. So we cannot use cluster UID as the tag. Instead what we will do is to generate UID in the defaulter and use that to tag the OCI resources. This UID will not changes as it is not the auto-generated tag.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #73